feat(tv-power): implement server PR1 with tests and documentation
This commit is contained in:
@@ -2,11 +2,200 @@
|
||||
|
||||
import os
|
||||
import logging
|
||||
from .db_utils import get_active_events, get_system_setting_value
|
||||
from .db_utils import (
|
||||
get_active_events,
|
||||
get_system_setting_value,
|
||||
compute_group_power_intent_basis,
|
||||
build_group_power_intent_body,
|
||||
compute_group_power_intent_fingerprint,
|
||||
)
|
||||
import paho.mqtt.client as mqtt
|
||||
import json
|
||||
import datetime
|
||||
import time
|
||||
import uuid
|
||||
|
||||
|
||||
def _to_utc_z(dt: datetime.datetime) -> str:
|
||||
if dt.tzinfo is None:
|
||||
dt = dt.replace(tzinfo=datetime.timezone.utc)
|
||||
else:
|
||||
dt = dt.astimezone(datetime.timezone.utc)
|
||||
return dt.isoformat().replace("+00:00", "Z")
|
||||
|
||||
|
||||
def _republish_cached_power_intents(client, last_power_intents, power_intent_metrics):
|
||||
if not last_power_intents:
|
||||
return
|
||||
|
||||
logging.info(
|
||||
"MQTT reconnect power-intent republish count=%s",
|
||||
len(last_power_intents),
|
||||
)
|
||||
for gid, cached in last_power_intents.items():
|
||||
topic = f"infoscreen/groups/{gid}/power/intent"
|
||||
client.publish(topic, cached["payload"], qos=1, retain=True)
|
||||
power_intent_metrics["retained_republish_total"] += 1
|
||||
|
||||
|
||||
def _publish_group_power_intents(
|
||||
client,
|
||||
events,
|
||||
now,
|
||||
poll_interval,
|
||||
heartbeat_enabled,
|
||||
expiry_multiplier,
|
||||
min_expiry_seconds,
|
||||
last_power_intents,
|
||||
power_intent_metrics,
|
||||
):
|
||||
expiry_seconds = max(
|
||||
expiry_multiplier * poll_interval,
|
||||
min_expiry_seconds,
|
||||
)
|
||||
|
||||
candidate_group_ids = set()
|
||||
for event in events:
|
||||
group_id = event.get("group_id")
|
||||
if group_id is None:
|
||||
continue
|
||||
try:
|
||||
candidate_group_ids.add(int(group_id))
|
||||
except (TypeError, ValueError):
|
||||
continue
|
||||
candidate_group_ids.update(last_power_intents.keys())
|
||||
|
||||
for gid in sorted(candidate_group_ids):
|
||||
# Guard: validate group_id is a valid positive integer
|
||||
if not isinstance(gid, int) or gid <= 0:
|
||||
logging.error(
|
||||
"event=power_intent_publish_error reason=invalid_group_id group_id=%s",
|
||||
gid,
|
||||
)
|
||||
continue
|
||||
|
||||
intent_basis = compute_group_power_intent_basis(
|
||||
events=events,
|
||||
group_id=gid,
|
||||
now_utc=now,
|
||||
adjacency_seconds=0,
|
||||
)
|
||||
intent_body = build_group_power_intent_body(
|
||||
intent_basis=intent_basis,
|
||||
poll_interval_sec=poll_interval,
|
||||
)
|
||||
fingerprint = compute_group_power_intent_fingerprint(intent_body)
|
||||
previous = last_power_intents.get(gid)
|
||||
is_transition_publish = previous is None or previous["fingerprint"] != fingerprint
|
||||
is_heartbeat_publish = bool(heartbeat_enabled and not is_transition_publish)
|
||||
|
||||
if not is_transition_publish and not is_heartbeat_publish:
|
||||
continue
|
||||
|
||||
intent_id = previous["intent_id"] if previous and not is_transition_publish else str(uuid.uuid4())
|
||||
|
||||
# Guard: validate intent_id is not empty
|
||||
if not intent_id or not isinstance(intent_id, str) or len(intent_id.strip()) == 0:
|
||||
logging.error(
|
||||
"event=power_intent_publish_error group_id=%s reason=invalid_intent_id",
|
||||
gid,
|
||||
)
|
||||
continue
|
||||
|
||||
issued_at = now
|
||||
expires_at = issued_at + datetime.timedelta(seconds=expiry_seconds)
|
||||
|
||||
# Guard: validate expiry window is positive and issued_at has valid timezone
|
||||
if expires_at <= issued_at:
|
||||
logging.error(
|
||||
"event=power_intent_publish_error group_id=%s reason=invalid_expiry issued_at=%s expires_at=%s",
|
||||
gid,
|
||||
_to_utc_z(issued_at),
|
||||
_to_utc_z(expires_at),
|
||||
)
|
||||
continue
|
||||
|
||||
issued_at_str = _to_utc_z(issued_at)
|
||||
expires_at_str = _to_utc_z(expires_at)
|
||||
|
||||
# Guard: ensure Z suffix on timestamps (format validation)
|
||||
if not issued_at_str.endswith("Z") or not expires_at_str.endswith("Z"):
|
||||
logging.error(
|
||||
"event=power_intent_publish_error group_id=%s reason=invalid_timestamp_format issued_at=%s expires_at=%s",
|
||||
gid,
|
||||
issued_at_str,
|
||||
expires_at_str,
|
||||
)
|
||||
continue
|
||||
|
||||
payload_dict = {
|
||||
**intent_body,
|
||||
"intent_id": intent_id,
|
||||
"issued_at": issued_at_str,
|
||||
"expires_at": expires_at_str,
|
||||
}
|
||||
|
||||
# Guard: ensure payload serialization succeeds before publishing
|
||||
try:
|
||||
payload = json.dumps(payload_dict, sort_keys=True, separators=(",", ":"))
|
||||
except (TypeError, ValueError) as e:
|
||||
logging.error(
|
||||
"event=power_intent_publish_error group_id=%s reason=payload_serialization_error error=%s",
|
||||
gid,
|
||||
str(e),
|
||||
)
|
||||
continue
|
||||
|
||||
topic = f"infoscreen/groups/{gid}/power/intent"
|
||||
|
||||
result = client.publish(topic, payload, qos=1, retain=True)
|
||||
result.wait_for_publish(timeout=5.0)
|
||||
if result.rc != mqtt.MQTT_ERR_SUCCESS:
|
||||
power_intent_metrics["publish_error_total"] += 1
|
||||
logging.error(
|
||||
"event=power_intent_publish_error group_id=%s desired_state=%s intent_id=%s "
|
||||
"transition_publish=%s heartbeat_publish=%s topic=%s qos=1 retained=true rc=%s",
|
||||
gid,
|
||||
payload_dict.get("desired_state"),
|
||||
intent_id,
|
||||
is_transition_publish,
|
||||
is_heartbeat_publish,
|
||||
topic,
|
||||
result.rc,
|
||||
)
|
||||
continue
|
||||
|
||||
last_power_intents[gid] = {
|
||||
"fingerprint": fingerprint,
|
||||
"intent_id": intent_id,
|
||||
"payload": payload,
|
||||
}
|
||||
if is_transition_publish:
|
||||
power_intent_metrics["intent_transitions_total"] += 1
|
||||
if is_heartbeat_publish:
|
||||
power_intent_metrics["heartbeat_republish_total"] += 1
|
||||
power_intent_metrics["publish_success_total"] += 1
|
||||
logging.info(
|
||||
"event=power_intent_publish group_id=%s desired_state=%s reason=%s intent_id=%s "
|
||||
"issued_at=%s expires_at=%s transition_publish=%s heartbeat_publish=%s "
|
||||
"topic=%s qos=1 retained=true",
|
||||
gid,
|
||||
payload_dict.get("desired_state"),
|
||||
payload_dict.get("reason"),
|
||||
intent_id,
|
||||
issued_at_str,
|
||||
expires_at_str,
|
||||
is_transition_publish,
|
||||
is_heartbeat_publish,
|
||||
topic,
|
||||
)
|
||||
|
||||
|
||||
def _env_bool(name: str, default: bool) -> bool:
|
||||
value = os.getenv(name)
|
||||
if value is None:
|
||||
return default
|
||||
return value.strip().lower() in ("1", "true", "yes", "on")
|
||||
|
||||
# Logging-Konfiguration
|
||||
from logging.handlers import RotatingFileHandler
|
||||
@@ -35,7 +224,7 @@ def main():
|
||||
client = mqtt.Client(callback_api_version=mqtt.CallbackAPIVersion.VERSION2)
|
||||
client.reconnect_delay_set(min_delay=1, max_delay=30)
|
||||
|
||||
POLL_INTERVAL = 30 # Sekunden, Empfehlung für seltene Änderungen
|
||||
POLL_INTERVAL = int(os.getenv("POLL_INTERVAL_SECONDS", "30"))
|
||||
# 0 = aus; z.B. 600 für alle 10 Min
|
||||
# initial value from DB or fallback to env
|
||||
try:
|
||||
@@ -43,10 +232,35 @@ def main():
|
||||
REFRESH_SECONDS = int(db_val) if db_val is not None else int(os.getenv("REFRESH_SECONDS", "0"))
|
||||
except Exception:
|
||||
REFRESH_SECONDS = int(os.getenv("REFRESH_SECONDS", "0"))
|
||||
|
||||
# TV power intent (PR-1): group-level publishing is feature-flagged and disabled by default.
|
||||
POWER_INTENT_PUBLISH_ENABLED = _env_bool("POWER_INTENT_PUBLISH_ENABLED", False)
|
||||
POWER_INTENT_HEARTBEAT_ENABLED = _env_bool("POWER_INTENT_HEARTBEAT_ENABLED", True)
|
||||
POWER_INTENT_EXPIRY_MULTIPLIER = int(os.getenv("POWER_INTENT_EXPIRY_MULTIPLIER", "3"))
|
||||
POWER_INTENT_MIN_EXPIRY_SECONDS = int(os.getenv("POWER_INTENT_MIN_EXPIRY_SECONDS", "90"))
|
||||
|
||||
logging.info(
|
||||
"Scheduler config: poll_interval=%ss refresh_seconds=%s power_intent_enabled=%s "
|
||||
"power_intent_heartbeat=%s power_intent_expiry_multiplier=%s power_intent_min_expiry=%ss",
|
||||
POLL_INTERVAL,
|
||||
REFRESH_SECONDS,
|
||||
POWER_INTENT_PUBLISH_ENABLED,
|
||||
POWER_INTENT_HEARTBEAT_ENABLED,
|
||||
POWER_INTENT_EXPIRY_MULTIPLIER,
|
||||
POWER_INTENT_MIN_EXPIRY_SECONDS,
|
||||
)
|
||||
# Konfigurierbares Zeitfenster in Tagen (Standard: 7)
|
||||
WINDOW_DAYS = int(os.getenv("EVENTS_WINDOW_DAYS", "7"))
|
||||
last_payloads = {} # group_id -> payload
|
||||
last_published_at = {} # group_id -> epoch seconds
|
||||
last_power_intents = {} # group_id -> {fingerprint, intent_id, payload}
|
||||
power_intent_metrics = {
|
||||
"intent_transitions_total": 0,
|
||||
"publish_success_total": 0,
|
||||
"publish_error_total": 0,
|
||||
"heartbeat_republish_total": 0,
|
||||
"retained_republish_total": 0,
|
||||
}
|
||||
|
||||
# Beim (Re-)Connect alle bekannten retained Payloads erneut senden
|
||||
def on_connect(client, userdata, flags, reasonCode, properties=None):
|
||||
@@ -56,6 +270,9 @@ def main():
|
||||
topic = f"infoscreen/events/{gid}"
|
||||
client.publish(topic, payload, retain=True)
|
||||
|
||||
if POWER_INTENT_PUBLISH_ENABLED:
|
||||
_republish_cached_power_intents(client, last_power_intents, power_intent_metrics)
|
||||
|
||||
client.on_connect = on_connect
|
||||
|
||||
client.connect("mqtt", 1883)
|
||||
@@ -150,6 +367,29 @@ def main():
|
||||
del last_payloads[gid]
|
||||
last_published_at.pop(gid, None)
|
||||
|
||||
if POWER_INTENT_PUBLISH_ENABLED:
|
||||
_publish_group_power_intents(
|
||||
client=client,
|
||||
events=events,
|
||||
now=now,
|
||||
poll_interval=POLL_INTERVAL,
|
||||
heartbeat_enabled=POWER_INTENT_HEARTBEAT_ENABLED,
|
||||
expiry_multiplier=POWER_INTENT_EXPIRY_MULTIPLIER,
|
||||
min_expiry_seconds=POWER_INTENT_MIN_EXPIRY_SECONDS,
|
||||
last_power_intents=last_power_intents,
|
||||
power_intent_metrics=power_intent_metrics,
|
||||
)
|
||||
|
||||
logging.debug(
|
||||
"event=power_intent_metrics intent_transitions_total=%s publish_success_total=%s "
|
||||
"publish_error_total=%s heartbeat_republish_total=%s retained_republish_total=%s",
|
||||
power_intent_metrics["intent_transitions_total"],
|
||||
power_intent_metrics["publish_success_total"],
|
||||
power_intent_metrics["publish_error_total"],
|
||||
power_intent_metrics["heartbeat_republish_total"],
|
||||
power_intent_metrics["retained_republish_total"],
|
||||
)
|
||||
|
||||
time.sleep(POLL_INTERVAL)
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user